Skip to content
This repository has been archived by the owner on Nov 8, 2017. It is now read-only.

Added listener. #14

Merged
merged 2 commits into from
May 26, 2015
Merged

Conversation

pedroadame
Copy link
Contributor

No description provided.

@rahatarmanahmed
Copy link
Owner

I'm on vacation right now, but glancing at it it looks good (unlike some other PRs i've gotten cough#2*cough*). One thing I might suggest is adding a CircularProgressViewAdapter class that implements CircularProgressViewListener with empty methods. See this SO answer for a good explanation on what an Adapter is.

@pedroadame
Copy link
Contributor Author

Done + bonus ;)

@rahatarmanahmed rahatarmanahmed merged commit aa9c22f into rahatarmanahmed:master May 26, 2015
@rahatarmanahmed
Copy link
Owner

Excellent, thanks.

Do note I did change how the listeners work a bit. Biggest change is allowing multiple listeners. onModeChange now only triggers when using setIndeterminate with a different value than it had previously. And the listener interface and adapter class are in their own files.

@pedroadame pedroadame deleted the develop branch May 26, 2015 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants