Fix fast refresh crash (wix#7371)

Closes wix#6176
rahimrahman · Nov 24, 2021 · 6452157 · 6452157
1 parent 709ddb8
commit 6452157
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/lib/ios/RNNBridgeManager.mm b/lib/ios/RNNBridgeManager.mm
@@ -113,7 +113,6 @@ - (void)onJavaScriptLoaded {
 - (void)onBridgeWillReload {
     dispatch_async(dispatch_get_main_queue(), ^{
       [self->_overlayManager dismissAllOverlays];
-      [self->_modalManager dismissAllModalsSynchronosly];
       [self->_componentRegistry clear];
       UIApplication.sharedApplication.delegate.window.rootViewController = nil;
     });

diff --git a/lib/ios/RNNModalManager.h b/lib/ios/RNNModalManager.h
@@ -22,7 +22,6 @@ typedef void (^RNNTransitionRejectionBlock)(NSString *_Nonnull code, NSString *_
             animated:(BOOL)animated
           completion:(RNNTransitionCompletionBlock _Nullable)completion;
 - (void)dismissAllModalsAnimated:(BOOL)animated completion:(void (^__nullable)(void))completion;
-- (void)dismissAllModalsSynchronosly;
 
 - (void)reset;
 

diff --git a/lib/ios/RNNModalManager.m b/lib/ios/RNNModalManager.m
@@ -130,21 +130,6 @@ - (void)dismissAllModalsAnimated:(BOOL)animated completion:(void (^__nullable)(v
         completion();
 }
 
-- (void)dismissAllModalsSynchronosly {
-    if (_presentedModals.count) {
-        dispatch_semaphore_t sem = dispatch_semaphore_create(0);
-        [self dismissAllModalsAnimated:NO
-                            completion:^{
-                              dispatch_semaphore_signal(sem);
-                            }];
-
-        while (dispatch_semaphore_wait(sem, DISPATCH_TIME_NOW)) {
-            [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode
-                                     beforeDate:[NSDate dateWithTimeIntervalSinceNow:0]];
-        }
-    }
-}
-
 - (void)reset {
     [_presentedModals removeAllObjects];
     [_pendingModalIdsToDismiss removeAllObjects];