Fixing rspec test, new Active Support convert_value method signature and version bump #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good. I can't believe I forgot to run the specs. Thanks for catching this. |
rahmal
pushed a commit
that referenced
this pull request
Feb 27, 2014
Fixing rspec test, new Active Support convert_value method signature and version bump
|
Merge completed. Next time, update the ChangeLog as well. Good work, and thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of the method HashWithIndifferentAccess#convert_value has changed in ActiveSupport 4.0.2: http://apidock.com/rails/v4.0.2/ActiveSupport/HashWithIndifferentAccess/convert_value
I also need to use and_call_original to make the test pass on spec/rconfig_spec.rb