dapp: fix version validation and comparison

The validation and comparison of version numbers for the update procedure was
broken. Reason was an updated version of the library that is used to work with
semantic version strings. In fact the interface of this library has changed (to
the better). For some reason the typing system did not detect this issue. The
fix is basically just an adaption of the imports from this library.

raiden-dapp/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+### Fixed
+
+- [#3021] Fix version handling to detect client updates
+
+[#3021]: https://github.com/raiden-network/light-client/issues/3021
+
 ## [2.0.0] - 2021-12-23
 
 ## [2.0.0-rc.2] - 2021-09-14

raiden-dapp/src/service-worker/assistant.ts

@@ -1,5 +1,5 @@
 /* istanbul ignore file */
-import compareVersions from 'compare-versions';
+import { validate as validateVersion } from 'compare-versions';
 import type { Store } from 'vuex';
 
 import type { CombinedStoreState } from '@/store/index';
@@ -52,7 +52,7 @@ export default class ServiceWorkerAssistant {
       const data = await response.json();
       const version = data.version.version;
 
-      if (compareVersions.validate(version)) {
+      if (validateVersion(version)) {
         this.store.commit('setAvailableVersion', version);
       } else {
         throw new Error(`Maleformed version string: ${version}`);

raiden-dapp/src/store/index.ts

@@ -1,4 +1,4 @@
-import compareVersions from 'compare-versions';
+import { compare as compareVersions, validate as validateVersion } from 'compare-versions';
 import type { BigNumber, providers } from 'ethers';
 import clone from 'lodash/clone';
 import filter from 'lodash/filter';
@@ -154,7 +154,7 @@ const store: StoreOptions<CombinedStoreState> = {
       state.stateBackupReminderDateMs = newReminderDate;
     },
     setAvailableVersion(state: RootState, version: string) {
-      if (compareVersions.validate(version)) {
+      if (validateVersion(version)) {
         state.versionInfo = { ...state.versionInfo, availableVersion: version };
       }
     },
@@ -258,7 +258,7 @@ const store: StoreOptions<CombinedStoreState> = {
       return (
         !!activeVersion &&
         !!availableVersion &&
-        compareVersions.compare(availableVersion, activeVersion, '>')
+        compareVersions(availableVersion, activeVersion, '>')
       );
     },
   },