Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.33.2 #1296

Merged
merged 13 commits into from Oct 18, 2019
Merged

Release 0.33.2 #1296

merged 13 commits into from Oct 18, 2019

Conversation

pirapira
Copy link
Contributor

What this PR does

This is a release PR for 0.33.2.

Why I'm making this PR

The previously made service contracts had configuration errors.

What's tricky about this PR (if any)

Nothing. Though it is big, it's mostly copying data into data_0.25.2.


Any reviewer can check these:

  • Squash unnecessary commits
  • Comment commits

And before "merge" all checkboxes have to be checked. If you find redundant points, remove them.

since we dropped the Kovan deployment files, we have to remove
the tests about them.
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1296 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1296   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          21       21           
  Lines        1464     1464           
  Branches      193      193           
=======================================
  Hits         1197     1197           
  Misses        228      228           
  Partials       39       39
Impacted Files Coverage Δ
raiden_contracts/constants.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e4800...a1bd2cd. Read the comment docs.

Copy link

@Dominik1999 Dominik1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants