Update FAQ #1324
Merged
Update FAQ #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
=======================================
Coverage 81.77% 81.77%
=======================================
Files 21 21
Lines 1465 1465
Branches 193 193
=======================================
Hits 1198 1198
Misses 228 228
Partials 39 39
Continue to review full report at Codecov.
|
rakanalh
reviewed
Oct 29, 2019
* the reason of existence of contracts_version has changed * now contracts_version bumps up to package_version roughly This closes raiden-network#1219.
So updating another entry in the FAQ.
pirapira
force-pushed
the
why-versions
branch
from
f0dc73b
to
2874a35
Compare
Recently the CI started using a newer version of black, so these changes are needed.
karlb
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1219.
What this PR does
Updates the FAQ about two points:
Why I'm making this PR
The FAQ was outdated.
What's tricky about this PR (if any)
Nothing.
Any reviewer can check these:
And before "merge" all checkboxes have to be checked. If you find redundant points, remove them.