Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SolC 0.8.6 #1517

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Update to SolC 0.8.6 #1517

merged 3 commits into from
Aug 12, 2021

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Aug 12, 2021

No description provided.

palango and others added 3 commits August 12, 2021 15:24
We can still consider using checked arithmetic in that place later. For
now, it is important to upgrade to a recent solc version.
Copy link
Contributor

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this in!

Could you please create an issue to track the removal of the unchecked blocks in the future?

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1517 (0b12995) into master (c23adf6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1517   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files          21       21           
  Lines        1541     1541           
  Branches      185      185           
=======================================
  Hits         1241     1241           
  Misses        253      253           
  Partials       47       47           
Impacted Files Coverage Δ
raiden_contracts/contract_source_manager.py 94.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23adf6...0b12995. Read the comment docs.

@karlb karlb marked this pull request as ready for review August 12, 2021 15:41
@karlb
Copy link
Contributor Author

karlb commented Aug 12, 2021

Issue for removal of unchecked blocks: #1518

@karlb karlb merged commit a65e2c7 into raiden-network:master Aug 12, 2021
@karlb karlb deleted the solc-0.8.6 branch August 12, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants