Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

Setters for auth and limit filter for matrix #153

Merged
merged 2 commits into from Dec 10, 2018
Merged

Setters for auth and limit filter for matrix #153

merged 2 commits into from Dec 10, 2018

Conversation

andrevmatos
Copy link
Contributor

Also, fix _sync call in MatrixClient constructor when token is passed failing due to _handle_thread not being set yet.
Part of raiden-network/raiden#3137

@andrevmatos andrevmatos added matrix Matrix Client related issues and PRs please review labels Dec 10, 2018
Copy link
Contributor

@ulope ulope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM.

@@ -401,6 +399,19 @@ def set_post_sync_hook(self, hook: Callable[[str], None]):
def set_sync_token(self, sync_token: str) -> None:
self.sync_token = sync_token

def set_access_token(self, user_id: str, token: str) -> None:
self.user_id = user_id
self.token = self.api.token = token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also need to set self.hs? (Although it seems that attribute isn't used for anything).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need, it isn't used by anything and not even every current login/register methods set it.

@andrevmatos andrevmatos merged commit 02987fb into raiden-network:master Dec 10, 2018
andrevmatos added a commit to raiden-network/raiden that referenced this pull request Dec 14, 2018
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 18, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 18, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 18, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 18, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 18, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 18, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 18, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 25, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 25, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 25, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 25, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 25, 2019
hackaugusto pushed a commit to hackaugusto/raiden that referenced this pull request Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
matrix Matrix Client related issues and PRs please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants