This repository has been archived by the owner on Mar 19, 2019. It is now read-only.
Setters for auth and limit filter for matrix #153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulope
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise LGTM.
@@ -401,6 +399,19 @@ def set_post_sync_hook(self, hook: Callable[[str], None]): | |||
def set_sync_token(self, sync_token: str) -> None: | |||
self.sync_token = sync_token | |||
|
|||
def set_access_token(self, user_id: str, token: str) -> None: | |||
self.user_id = user_id | |||
self.token = self.api.token = token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this also need to set self.hs
? (Although it seems that attribute isn't used for anything).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need, it isn't used by anything and not even every current login/register methods set it.
andrevmatos
added a commit
to raiden-network/raiden
that referenced
this pull request
Dec 14, 2018
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 18, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 18, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 18, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 18, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 18, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 18, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 18, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 25, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 25, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 25, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 25, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 25, 2019
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this pull request
Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix
_sync
call inMatrixClient
constructor whentoken
is passed failing due to_handle_thread
not being set yet.Part of raiden-network/raiden#3137