Remove handling of ChannelNewDeposit event #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling the event turned out to be a source of issues. Besides, it doesn't provide any advantages over just using the capacity updates from the nodes. This commit removes all internal handling of the deposit event. Fixes raiden-network#494
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 90.71% 91.04% +0.32%
==========================================
Files 35 35
Lines 2252 2211 -41
Branches 291 282 -9
==========================================
- Hits 2043 2013 -30
+ Misses 155 149 -6
+ Partials 54 49 -5
Continue to review full report at Codecov.
|
karlb
approved these changes
Aug 1, 2019
| @@ -112,7 +94,7 @@ def test_pfs_rejects_capacity_update_with_wrong_chain_id( | |||
| ): | |||
| setup_channel(pathfinding_service_web3_mock) | |||
|
|
|||
| message = get_updatepfs_message( | |||
| message = get_capacity_update_message( | |||
There was a problem hiding this comment.
Good that you changed that, too! I already though we got all the updatepfs occurrences last time...
tests/pathfinding/test_graphs.py
Outdated
| @@ -99,7 +99,7 @@ def test_routing_simple( | |||
| view01: ChannelView = token_network_model.G[addresses[0]][addresses[1]]["view"] | |||
| view10: ChannelView = token_network_model.G[addresses[1]][addresses[0]]["view"] | |||
|
|
|||
| assert view01.deposit == 100 | |||
| # assert view01.deposit == 100 | |||
There was a problem hiding this comment.
Classic, I was sure I would remember to remove this once the tests pass :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling the event turned out to be a source of issues. Besides, it
doesn't provide any advantages over just using the capacity updates from
the nodes.
This commit removes all internal handling of the deposit event.
Fixes #494