Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a timeout in shutdown sequence #1149

Closed
palango opened this issue Nov 23, 2017 · 4 comments
Closed

Don't use a timeout in shutdown sequence #1149

palango opened this issue Nov 23, 2017 · 4 comments

Comments

@palango
Copy link
Contributor

palango commented Nov 23, 2017

Problem Definition

Currently a timeout is used in the shutdown sequence if the ethereum node in not reachable.

Solution

Instead of using a client that tries to reconnect and giving it a timeout we should use a client that doesn't try to reconnect.

@hackaugusto hackaugusto changed the title Don't use a timout in shutdown sequence Don't use a timeout in shutdown sequence Nov 29, 2017
@palango
Copy link
Contributor Author

palango commented Aug 24, 2018

@hackaugusto The original cause of this issue is gone, but there is still a timeout:

try:
with gevent.Timeout(self.shutdown_timeout):
self.blockchain_events.uninstall_all_event_listeners()
except (gevent.timeout.Timeout, RaidenShuttingDown):
pass

@andrevmatos
Copy link
Contributor

@palango I should be removing that one in #2208, then the only stop/shutdown timeout left should be the one in cli's _run_app

@palango
Copy link
Contributor Author

palango commented Aug 24, 2018

Nice, then just add this as a fixed issue there.

@andrevmatos
Copy link
Contributor

Fixed by #2208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants