Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lithium Sulfur Battery in the wrong group #67

Closed
Blackclaws opened this issue Nov 8, 2021 · 6 comments
Closed

Lithium Sulfur Battery in the wrong group #67

Blackclaws opened this issue Nov 8, 2021 · 6 comments
Assignees
Labels
bug Something isn't working pending Further information is required.

Comments

@Blackclaws
Copy link

Description

Lithium Sulfur Batteries are in the Ressources group while any other type of battery is in the manufacturing group. This is a bit weird.

Reproduction

  1. Open Menu

Factorio version

1.1.46

In-game username

Blackclaws

@Blackclaws Blackclaws added the bug Something isn't working label Nov 8, 2021
@raiguard
Copy link
Owner

raiguard commented Nov 9, 2021

image
Regular batteries are in the raw-material group as well.

Could you please upload your save file?

@raiguard raiguard added the pending Further information is required. label Nov 9, 2021
@Blackclaws
Copy link
Author

Ah, my bad... Space Exploration does move it to manufacturing ... so Krastorio is being consistent here and Space Exploration is inconsistent. That being said batteries being raw material in Vanilla does seem weird to me now that I think about it. This could be something that might be added to SE postprocessing for consistencies sake.
If you like feel free to close this as working as intended.

@GeneralTanker
Copy link

Also the icon for Lithium Sulfur Battery needs and update to match the new vanilla icon.

@raiguard
Copy link
Owner

raiguard commented Nov 9, 2021

I do not have any artistic skill whatsoever beyond tinting, so that's probably not going to happen. Sorry.

As for the item group, I'll update the SE compatibility code to move it to the correct place.

@GeneralTanker
Copy link

That might be all you need sense what I was talking about was have the Lithium Sulfur Battery have the same basic icon as the vanilla battery but with a different color. This example from Artisanal Reskins Bob's is what I'm looking for mostly for consistency.

Battery example Artisanal Reskins for Bobs 11-9-2021

@raiguard
Copy link
Owner

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending Further information is required.
Projects
None yet
Development

No branches or pull requests

3 participants