Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAC HER example results not matching #49

Closed
Shade5 opened this issue Apr 22, 2019 · 7 comments
Closed

SAC HER example results not matching #49

Shade5 opened this issue Apr 22, 2019 · 7 comments

Comments

@Shade5
Copy link

Shade5 commented Apr 22, 2019

I cloned the repo, setup the environment and ran (made no changes)

python her_sac_gym_fetch_reach.py

The results don't seem to match with this. Did something break in the latest commit?

image

However, when I try the td3, it works fine

python her_td3_multiworld_sawyer_reach.py

image

@vitchyr
Copy link
Collaborator

vitchyr commented Apr 22, 2019

Can you run multiple seeds? I included 5 separate runs since it does tend to fail sometimes.

@Shade5
Copy link
Author

Shade5 commented Apr 22, 2019

Sorry, but I can't seem to find the right place to set the seeds. Would you link me to a line number?

@vitchyr
Copy link
Collaborator

vitchyr commented Apr 22, 2019 via email

@Shade5
Copy link
Author

Shade5 commented Apr 22, 2019

Yes, some of them work now, thanks.

image

@Shade5 Shade5 closed this as completed Apr 22, 2019
@Shade5
Copy link
Author

Shade5 commented Apr 24, 2019

On a side note, I was trying FetchPush-v1. The only changes I need to make is in gym.make(... ) right?

If so, I've tried multiple seeds with about 500 iterations, with no progress. Am I missing something? What's the expected time?

@vitchyr
Copy link
Collaborator

vitchyr commented Apr 24, 2019

Based on this paper, it seems like you need one millions steps, so probably (1000 iterations).

But they also use DDPG with an epsilon greedy exploration policy, so that might matter.

@Shade5
Copy link
Author

Shade5 commented Apr 27, 2019

For other users to confirm their results, here's FetchPush-v1 for 3 seeds.
image

Here's the results for 3 seeds on FetchPickAndPlace-v1
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants