Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval statistics for SAC #51

Closed
amandlek opened this issue Apr 25, 2019 · 2 comments
Closed

Eval statistics for SAC #51

amandlek opened this issue Apr 25, 2019 · 2 comments

Comments

@amandlek
Copy link

amandlek commented Apr 25, 2019

I had a question about the way evaluation statistics are computed for SAC - from taking a look at the code, it seems as though the statistics will only be computed over one particular training batch every epoch (https://github.com/vitchyr/rlkit/blob/master/rlkit/torch/sac/sac.py#L161), is this true? I'd imagine that this measurement would be pretty high variance, as opposed to averaging the statistics over all batches in the epoch. Could you clarify if this is the case and if so, why you've implemented logging in this way?

@amandlek amandlek changed the title Eval s Eval statistics for SAC Apr 25, 2019
@amandlek amandlek reopened this Apr 25, 2019
@vitchyr
Copy link
Collaborator

vitchyr commented Apr 25, 2019

Yes, that's how it's implemented. It's mainly because I figured it'd be faster and would save memory. But on second thought, it's probably not too costly to keep track of all stats. Still, the current way has been good enough for me. Feel free to make a PR implementing this change.

@amandlek
Copy link
Author

Thanks for the quick reply!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants