allow for type attribute #1037
Merged
allow for type attribute #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_type_attribute_override | ||
| attribute_serializer = Class.new(ActiveModel::Serializer) do | ||
| attribute :id, key: :type |
There was a problem hiding this comment.
nitpick: it's not an override anymore if the internal name is now 'json_api_type', right?
|
@lanej Could you please rebase and squash it? 😁 |
* don't overshadow serializer variable
* "namespace" json_api specific type method
ey-pairing
force-pushed
the
type-attribute
branch
from
3b45bd1
to
033ce8e
Compare
|
@joaomdmoura rebased. |
|
Great, I'm merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.