Let FlattenJson adapter decide it doesn't include meta #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bf4
changed the title
|
👍 |
|
@joaomdmoura any objections to moving the include_meta unless FlattenJson from the Adapter class to the FlattenJson class? |
|
|
||
| private | ||
|
|
||
| # no-op |
There was a problem hiding this comment.
What about a more specific comment, nothing big, just to help ppl jumping in the code.
There was a problem hiding this comment.
no-op: The FlattenJson adapter does not include meta data? no-op: The FlattenJson adapter only serializes attributes?
There was a problem hiding this comment.
no-op: FlattenJson adapter does not include meta data, because it does not support root. 😄
|
👍 LGTM, just waiting for the comment before merging. |
bf4
force-pushed
the
cleanup_meta_in_adapter
branch
from
8b50d37
to
98d009a
Compare
|
updated |
|
Great! I'm merging it. |
joaomdmoura
added a commit
that referenced
this pull request
Aug 18, 2015
Let FlattenJson adapter decide it doesn't include meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why should the superclass get to decide it wants to
exclude meta from one of its subclasses. I say don't ask
if we're a FlattenJson adapter, tell the adapter to
include the meta and let FlattenJson no-op on it.
From discussion in #1041