Introduce Adapter::Base #1138
Merged
Introduce Adapter::Base #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,30 +1,33 @@ | |||
| module ActiveModel | |||
| class Serializer | |||
| class Adapter | |||
| module Adapter | |||
bf4
force-pushed
the
introduce_adapter_base
branch
4 times, most recently
from
0c16fe8
to
b6e3a96
Compare
| class << self # All methods are class functions | ||
| def new(*args) | ||
| fail ArgumentError, [args, caller[0]].inspect | ||
| end |
There was a problem hiding this comment.
Just in case.. but perhaps I could write a better message.. is really meant to be a helpful deprecation fast failure
bf4
force-pushed
the
introduce_adapter_base
branch
from
b6e3a96
to
32a1a16
Compare
|
Are you gonna add to changlog and document the breaking change in this PR? |
|
otherwise 👍 |
|
ping @bf4 |
Breaking change: - Adapters now inherit Adapter::Base - 'Adapter' is now a module, no longer a class Why? - using a class as a namespace that you also inherit from is complicated and circular at time i.e. buggy (see rails-api#1177) - The class methods on Adapter aren't necessarily related to the instance methods, they're more Adapter functions - named `Base` because it's a Rails-ism - It helps to isolate and highlight what the Adapter interface actually is
bf4
force-pushed
the
introduce_adapter_base
branch
from
32a1a16
to
19de5f7
Compare
| end | ||
|
|
||
| def root | ||
| serializer.json_key.to_sym if serializer.json_key |
There was a problem hiding this comment.
What's the rationale behind calling it root in the adapter and json_key in the serializer?
|
LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Basebecause it's a Rails-ismTODO