Better serializer registration, get more than just the first module #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +81,7 @@ def find_by_name(adapter_name) | |||
|
|
|||
| # Automatically register adapters when subclassing | |||
|
looks like there was an error with a bunch of the tests. |
|
all on rails 4.0 |
|
history got borked somehwere |
|
:-( |
bf4
force-pushed
the
better_adapter_registration
branch
from
073d9f2
to
c2536b0
Compare
|
fixed |
|
Weird appveyor fails on SimpleCov 58% on Rails 4.0.. no idea why |
|
Travis is still failingmon rails 4.0 as well. Can you run against 4.0 locally and see if that'll give you any insight? crosses fingers |
|
@NullVoxPopuli Since it's different, I usually develop with |
bf4
force-pushed
the
better_adapter_registration
branch
2 times, most recently
from
4f22e94
to
edf30bb
Compare
But is potentially breaking anyone on rc3, but the fix is just to manually register the adapter with the rc3-style name
bf4
force-pushed
the
better_adapter_registration
branch
from
edf30bb
to
eb1264a
Compare
|
Thanks for fixing! |
NullVoxPopuli
added a commit
that referenced
this pull request
Sep 18, 2015
Better serializer registration, get more than just the first module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But is potentially breaking anyone on rc3, but the fix is just
to manually register the adapter with the rc3-style name