Serialization and Cache Documentation #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
changed the title
|
yay documentation! omg :-) |
|
@bf4 Any specific reason not to break it into 3 PRs? |
|
No, just kept writing and sometimes more is harder to review. B mobile phone
|
| @@ -127,6 +199,9 @@ def self.get_serializer_for(klass) | |||
| attr_accessor :object, :root, :scope | |||
| class_attribute :_type, instance_writer: false | |||
|
|
|||
| # `scope_name` is set as :current_user by default in the controller. | |||
| # If the instance does not have a method nameed `scope_name`, it | |||
| class << self | ||
| attr_accessor :_attributes | ||
| attr_accessor :_attributes_keys | ||
| # Hashes contents of file for +_cache_digest+ |
There was a problem hiding this comment.
Could you elaborate (just for my personal understanding) on which practical situations the error is thrown?
There was a problem hiding this comment.
Sorry I didn't call this out better. I included it in the PR description for the change: #1176
This was referenced Oct 15, 2015
bf4
force-pushed
the
serializer_cache_digest
branch
from
c678a3a
to
60df36b
Compare
bf4
changed the title
| end | ||
|
|
||
| serializer.class_attribute :_cache # @api private : the cache object | ||
| serializer.class_attribute :_fragmented # @api private : |
|
A few minor comments but great work nonetheless. |
bf4
force-pushed
the
serializer_cache_digest
branch
from
9648a9c
to
274cb66
Compare
|
Look good? |
|
omg, yes. |
bf4
added a commit
that referenced
this pull request
Oct 22, 2015
Serialization and Cache Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(other work extracted into #1271 #1272)