SerializableResource handles no serializer like controller #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
more_controller_logic_to_serializable_resource
branch
from
4a98876
to
277c5a3
Compare
| # For compatibility with the JSON renderer: `json.to_json(options) if json.is_a?(String)`. | ||
| # Otherwise, since `serializable_resource` is not a string, the renderer would call | ||
| # `to_json` on a String and given odd results, such as `"".to_json #=> '""'` | ||
| serializable_resource.adapter.is_a?(String) ? serializable_resource.adapter : serializable_resource |
There was a problem hiding this comment.
Does that mean that someone would try to serialize a string directly?
There was a problem hiding this comment.
No... as per the comment, this handles render {foo: :bar}.to_json
|
@groyoh I don't have these failures locally. It makes it hard for me to debug |
|
@bf4 yeah, I actually tried it it out too earlier. Restarted the build too and couldn't figure out what's going on. |
bf4
force-pushed
the
more_controller_logic_to_serializable_resource
branch
from
277c5a3
to
84197e4
Compare
bf4
force-pushed
the
more_controller_logic_to_serializable_resource
branch
2 times, most recently
from
c206c7c
to
6a60d45
Compare
|
@groyoh I believe it's related to the notifications being passed a nil serializer since that can now happen |
bf4
force-pushed
the
more_controller_logic_to_serializable_resource
branch
from
6a60d45
to
ec5dc49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes when passing in a resource to SerializableResource outside of a controller, a
resource without a known Serializer will no longer raise
NoMethodError: undefined method 'new' for nil:NilClass, but will behave like thecontroller and just use the resource, as is.
Follows #1580 (comment)