Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cache_store reference explicit #1637

Merged
merged 2 commits into from
Mar 31, 2016
Merged

Make cache_store reference explicit #1637

merged 2 commits into from
Mar 31, 2016

Conversation

ncuesta
Copy link
Contributor

@ncuesta ncuesta commented Mar 31, 2016

Purpose

Fix issue reported in this comment from issue #1634.

Changes

Makes cache_store reference explicit.

Caveats

None.

Related GitHub issues

#1634

Additional helpful information

This avoids an issue when the base class for application's controllers inherit from ActionController::API instead of ActionController::Base.

This avoids an issue when the base class for application's controllers inherit from `ActionController::API` instead of `ActionController::Base`.
@bf4
Copy link
Member

bf4 commented Mar 31, 2016

Awesome @ncuesta . Would you mind adding a changelog? Would you be interested in adding a simple rails-api test for this? I would be willing to help.

@ncuesta
Copy link
Contributor Author

ncuesta commented Mar 31, 2016

Thanks for the suggestions @bf4! I've added the Changelog entry. I'll try to add the tests later, but could you please merge this PR so we can fix this issue on our application now?

@bf4
Copy link
Member

bf4 commented Mar 31, 2016

Sure, and release rc5 soon

B mobile phone

On Mar 31, 2016, at 7:09 AM, Nahuel Cuesta Luengo notifications@github.com wrote:

Thanks for the suggestions @bf4! I've added the Changelog entry. I'll try to add the tests later, but could you please merge this PR so we can fix this issue on our application now?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@bf4 bf4 merged commit f2755d6 into rails-api:master Mar 31, 2016
@bf4
Copy link
Member

bf4 commented Mar 31, 2016

Awesome, 💯 thanks for the quick response @ncuesta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants