use _ids method instead of pluck to embed ids #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, apparently this is fixed in Rails master: rails/rails@a878126 Not much help to most users though and would cause an exception if used with >3.2 and <3.2.10. |
|
🤘 let's merge this then. Thank you! ❤️ |
steveklabnik
added a commit
that referenced
this pull request
Dec 21, 2012
use _ids method instead of pluck to embed ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to do this but there was a problem with PR #176. If you use
pluckto select theidcolumn on ahas_many throughassociation, theidcolumn won't be disambiguated. However, you can use theassociation_idsmethod instead to achieve the same effect aspluckbut with disambiguation.I think
pluckshould probably disambiguate the column name, but in the interim this fixes the problem. Sorry for not noticing this sooner.