Namespace separator setting for json-api and tests #1791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentation Type transform setting and transformer, name fixed in tests
BF4: Changelog added Conflicts resolved: test/adapter/json_api/linked_test.rb test/adapter/json_api/resource_identifier_test.rb
| @@ -22,6 +22,8 @@ def config.array_serializer | |||
| config.default_includes = '*' | |||
| config.adapter = :attributes | |||
| config.jsonapi_resource_type = :plural | |||
| config.jsonapi_namespace_separator = '--'.freeze | |||
| config.jsonapi_type_transform = :underscore | |||
There was a problem hiding this comment.
type transform is underscore? doesn't this go against our other transform?
There was a problem hiding this comment.
Yup... This is why it needs a thoughtful review :)
B mobile phone
On Jun 9, 2016, at 3:54 AM, L. Preston Sego III notifications@github.com wrote:
In lib/active_model/serializer/configuration.rb:
@@ -22,6 +22,8 @@ def config.array_serializer
config.default_includes = '*'
config.adapter = :attributes
config.jsonapi_resource_type = :plural
config.jsonapi_namespace_separator = '--'.freezeconfig.jsonapi_type_transform = :underscore—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
There was a problem hiding this comment.
What if we had the default what it is now?
|
Superseded by #1874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I resolved #1609,
merged into master, and would like @remear and @youroff to review for any
changes, since I'm merging this after changes in the KeyTransform code were made.