Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rendering.md #1799

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Update rendering.md #1799

merged 1 commit into from
Aug 31, 2016

Conversation

cassidycodes
Copy link
Contributor

Purpose

Documenting the adapter option in the rendering guide.

Changes

Adding a description of the adapter option to the Guides.

Caveats

Related GitHub issues

None. PR made as per notes in guides.

Additional helpful information

@NullVoxPopuli
Copy link
Contributor

Lgtm. 👍

@bf4
Copy link
Member

bf4 commented Jun 14, 2016

@ScottKbka mind giving yourself credit in the misc section of the CHANGELOG?

@cassidycodes
Copy link
Contributor Author

@bf4 Sure! Hoping to make more significant contributions down the road. Always happy to write docs though

@@ -1,109 +1,99 @@
## 0.10.x
# 0.10.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does look better even though I think there's never supposed to be >1 h1 on a page :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, mind making these changes to the changelog in a separate pr and explain some of the changes you're making?

Would be better for feedback since 0.10.1 is now released and there are merge conflicts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do! Honestly, I might have accidentally hit backspace on that line. I don't remember doing that!

@cassidycodes
Copy link
Contributor Author

@bf4 I'll have to do this later. Today's been a busy day. I'll fix the merge conflicts and let you know when it's done. 😸

@bf4
Copy link
Member

bf4 commented Aug 17, 2016

@ScottKbka Hey, you interested in helping finish this one?

@cassidycodes
Copy link
Contributor Author

@bf4 Where has this summer gone! Thanks for pinging me, I've been distracted here : ) It should all be fixed up now.

@jgrau
Copy link
Contributor

jgrau commented Aug 31, 2016

LGTM 👍

@bf4 bf4 merged commit d34069b into rails-api:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants