Add documentation on upgrading from 0.8 to 0.10 safely
#1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkoltai, thanks for your PR! By analyzing the annotation information on this pull request, we identified @joaomdmoura, @bf4 and @NullVoxPopuli to be potential reviewers |
| # ` || object.respond_to?(a.first)` to check if the object responded to | ||
| # the given method. | ||
| def try(*a, &b) | ||
| if a.empty? || respond_to?(a.first) || object.respond_to?(a.first) |
There was a problem hiding this comment.
probably respond_to?(a.first, true) to include protected methods IIRC
|
omg @bkoltai you are super 👍 💯 to so many people 🎉 🌈 🐴 💃 |
- Add list of breaking changes - Add `true` param to `responds_to?` calls in overriden `try`
| ## Disclaimer | ||
| ### Proceed at your own risk | ||
| This document attempts to outline steps to upgrade your app based on the collective experience of | ||
| developers who have done this already. It may not cover all edge cases and situation that may cause issues, |
bkoltai
force-pushed
the
bk_upgrade_0_8_to_0_10_doc
branch
4 times, most recently
from
9acc6fa
to
f98cac5
Compare
bkoltai
force-pushed
the
bk_upgrade_0_8_to_0_10_doc
branch
from
f98cac5
to
d9ba5cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Provide guidance on how to upgrade from
0.8to0.10safely, based on my experience recently upgrading my0.8.3app to0.10.2successfully.Changes
Adds
docs/howto/upgrade_from_0_8_to_0_10.mdCaveats
The upgrade doc may not contain all edge cases and possible issues during migration. It is purely a documentation of the process that worked for my app.
It maybe be that this is more useful as a gem or some other way with proper testing. Unfortunately, I don't think I'll have time to do this myself, but I wanted to get this out so that someone else could move forward with their migration and contribute a gem that encapsulates the code snippets I provide with proper testing. I hope this document is still useful without this.
Related GitHub issues
#1694
#1005