Correct comment #1887
Merged
Correct comment #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnnymo87, thanks for your PR! By analyzing the annotation information on this pull request, we identified @groyoh and @bf4 to be potential reviewers |
|
Nice find! Would you like to add a changelog to take credit for the correction? |
| @@ -49,7 +49,7 @@ def serializer_instance | |||
|
|
|||
| # Get serializer either explicitly :serializer or implicitly from resource | |||
| # Remove :serializer key from serializer_opts | |||
| # Replace :serializer key with :each_serializer if present | |||
| # Replace :each_serializer key with :serializer if present | |||
There was a problem hiding this comment.
Hmm, I don't think it's exactly clear either way, now that I look at it. Should be
Remove
:each_serializerif present and set as:serializerkey
johnnymo87
force-pushed
the
correct-comment
branch
from
7c8f58c
to
f96d97d
Compare
|
@NullVoxPopuli @bf4 updated |
|
@johnnymo87 Merged. Sorry I missed this was ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make the comment reflect what the function does
Changes
Correct comment