Disable pagination links via config #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richmolj
force-pushed
the
disable_pagination_links
branch
from
7241ce5
to
adba526
Compare
| @@ -52,6 +52,8 @@ def json_key | |||
| # rubocop:enable Metrics/CyclomaticComplexity | |||
|
|
|||
| def paginated? | |||
| return false unless Serializer.config.jsonapi_pagination_links_enabled | |||
|
|
|||
There was a problem hiding this comment.
or just ActiveModelSerializers.config.jsonapi_pagination_links_enabled && :)
richmolj
force-pushed
the
disable_pagination_links
branch
from
adba526
to
55fe981
Compare
| @@ -52,7 +52,8 @@ def json_key | |||
| # rubocop:enable Metrics/CyclomaticComplexity | |||
|
|
|||
| def paginated? | |||
| object.respond_to?(:current_page) && | |||
| Serializer.config.jsonapi_pagination_links_enabled && | |||
There was a problem hiding this comment.
s/Serializer/ActiveModelSerializers. the Serializer is no longer the primary object..
There was a problem hiding this comment.
Did not realize this, thank you. Changed.
richmolj
force-pushed
the
disable_pagination_links
branch
from
55fe981
to
19b5abf
Compare
|
@richmolj You wanna merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add configuration option to disable automatic jsonapi pagination links.
As my application does not make use of these links, I'd like to avoid the extra database query they cause (a
countto get the total pages).Changes
Adds
ActiveModel::Serializer.config.jsonapi_pagination_links_enabled. Default istrue.Related GitHub issues
#1596
#1823