Better AMS Model attributes interface #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bf4, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mateomurphy, @NullVoxPopuli and @ggordon to be potential reviewers. |
bf4
force-pushed
the
better_ams_model_interface
branch
2 times, most recently
from
438dbed
to
e4af564
Compare
| # # in Rails 5 | ||
| # def respond_to_missing?(method_name, _include_private = false) | ||
| # attributes.key?(method_name.to_s.tr('=', '').to_sym) || super | ||
| # end |
|
I really like the explicitness this enforces throughout tests. |
bf4
force-pushed
the
better_ams_model_interface
branch
from
6e5f355
to
772b799
Compare
This was referenced Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #1903