Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop binstub that respects file patterns #2072

Merged
merged 1 commit into from
Mar 12, 2017

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Mar 12, 2017

Best of both worlds!

(Because you can't override the default rubocop includes)

The binstub basically, lets me safely rubocop test/foo_test.rb
instead of bundle exec rubocop test/foo_test.rb

  # ~/.profile
  # https://twitter.com/tpope/status/165631968996900865
  # tl;dr `mkdir .git/safe` to add `bin` to path, e.g. `bin/rails`
  PATH=".git/safe/../../bin:$PATH"

Best of both worlds!

(Because you can't override the default rubocop includes)

The binstub basically, lets me safely `rubocop test/foo_test.rb`
instead of `bundle exec rubocop test/foo_test.rb`

```bash
  # ~/.profile
  # https://twitter.com/tpope/status/165631968996900865
  # tl;dr `mkdir .git/safe` to add `bin` to path, e.g. `bin/rails`
  PATH=".git/safe/../../bin:$PATH"
```
@mention-bot
Copy link

@bf4, thanks for your PR! By analyzing the history of the files in this pull request, we identified @remear, @dubadub and @steveklabnik to be potential reviewers.

@bf4 bf4 merged commit 87e929a into rails-api:master Mar 12, 2017
@bf4 bf4 deleted the more_precise_rubocop branch March 12, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants