Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that serializer could not be found if the association's s… #2296

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix the bug that serializer could not be found if the association's s… #2296

merged 1 commit into from
Oct 24, 2018

Conversation

Hirurg103
Copy link

…erializer is namespaced but the model is not

[fix #2295]

…erializer is namespaced but the model is not

[fix #2295]
@bf4
Copy link
Member

bf4 commented Oct 22, 2018

Hmm, built failure appears unrelated, just JRUBY

  1) Failure:
ActiveModelSerializers::CacheTest#test_uses_adapter_in_cache_key [/home/travis/build/rails-api/active_model_serializers/test/cache_test.rb:305]:
--- expected
+++ actual
@@ -1 +1 @@
-{:id=>"post", :title=>"New Post", :body=>"Body"}
+nil

@Hirurg103
Copy link
Author

Hi @bf4 could you please review this PR and merge it if it is OK

@bf4
Copy link
Member

bf4 commented Oct 23, 2018

Yes, I'll get to it today

@Hirurg103
Copy link
Author

Thank you @bf4

@bf4
Copy link
Member

bf4 commented Oct 23, 2018

Didn't do it yet. was writing some epic postgresql at the office

@Hirurg103
Copy link
Author

Hi @bf4, it happens, no problem at all

@bf4
Copy link
Member

bf4 commented Oct 24, 2018

Confirmed your test is good. Could no reproduce jruby failure with my local version of JRuby and Rails 4.1

@bf4 bf4 merged commit db4e526 into rails-api:0-10-stable Oct 24, 2018
@Hirurg103
Copy link
Author

Thanks for reviewing and merging my fix, @bf4 ! Can I close #2295 now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants