Stick to bundler version < 2 on AppVeyor #2321
Conversation
iggant
force-pushed
the
0-10-stable
branch
2 times, most recently
from
1d3c98d
to
fd1116c
Compare
|
@iggant you're welcome to keep plugging at this! |
|
Travis issue with If we do that, new PRs will have at least 1 less problem to solve :) |
iggant
force-pushed
the
0-10-stable
branch
7 times, most recently
from
b1a3105
to
9a8460c
Compare
|
@iggant would you mind rebasing the PR on latest |
|
@wasifhossain yes will do this on Friday |
iggant
force-pushed
the
0-10-stable
branch
3 times, most recently
from
dd17f4c
to
25cccde
Compare
|
@wasifhossain rebased and squashed |
| @@ -164,7 +164,7 @@ def test_expiring_of_cache_at_update_of_record | |||
|
|
|||
| assert_equal 'Foo', author_json[:name] | |||
|
|
|||
| author.update_attributes(name: 'Bar') | |||
| author.update(name: 'Bar') | |||
| @@ -202,10 +202,12 @@ def test_cache_expiration_in_collection_on_update_of_record | |||
| end | |||
|
|
|||
| bar = 'Bar' | |||
| author.update!(name: bar) | |||
| Timecop.travel(10.seconds.from_now) do | |||
There was a problem hiding this comment.
@iggant can you please elaborate the case why you need Timecop in this case?
There was a problem hiding this comment.
before this change there were random test failture
probably this is because cache version relay on updated_at column which doesn't contain millisecond part, so time to time it doesn't invalidate cache.
and with travel to 10 second ahead we eliminate this possibility
probably current check in the 172 line is also related, but I will thy to change that test in the next PR
There was a problem hiding this comment.
perfect reason 👌 can't wait to see you apply the same logic for the other test too on line 167. You can do it in your next PR. Then we may also be able to remove these weird checks
if ENV['APPVEYOR'] && actual != expected
skip('Cache expiration tests sometimes fail on Appveyor. FIXME :)')
|
@iggant thanks a lot for your effort. Appveyor became green again 🙌 |
|
@wasifhossain made requested changed |
wasifhossain
changed the title
Force AppVeyor to follow the bundler version constraint