test(ci): github #2447
Merged
test(ci): github #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
09-ci
branch
2 times, most recently
from
00cbb77
to
c9682e7
Compare
|
@bf4 would love to take a look at this and revive this. Is there a better way for me to update code directly to this branch as oppose to creating a PR to merge into this branch just to test CI? |
|
@Physium I've invited you as a collaborator. Looking forward to having your assistance:) |
|
@bf4 Tweaked a couple of things to get the pipeline going. I removed 4.1 and 4.0 rails version from the matrix for now. Personally feel that its not worth the effort having this much backwards compatibility. |
|
let me know whenever if its good to go or pending a review! |
|
@Physium if it works for you, it works for me. :) |
bf4
commented
Jul 7, 2023
| @@ -36,6 +36,9 @@ if RUBY_VERSION < '2' | |||
| end | |||
|
|
|||
| if ENV['CI'] | |||
| # loofah has a breaking change 2.21 onwards which does not work with < 2.5 ruby | |||
| gem 'loofah', '< 2.21' if RUBY_VERSION < '2.5' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
Caveats
Related GitHub issues
Additional helpful information