Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update active_model_serializers.gemspec #2452

Closed

Conversation

kalashnikovisme
Copy link

Purpose

To use this gem with Rails 7.1.0 project.

Changes

Upgrade rails_versions in dependencies

Additional helpful information

All tests (around 500) are passed in our projects.

@wasifhossain
Copy link
Member

Thank you @kalashnikovisme for your PR! Also great to hear that your test suite is happy with the change.

Still if you don't mind, can we close this in favor of #2453 ?

@kalashnikovisme
Copy link
Author

@wasifhossain oh, of course! I had not found that one, so created mine 😄

@wasifhossain
Copy link
Member

you are right, because the other one was created after yours, but with the updated test matrix 😅

thank you!

@kalashnikovisme kalashnikovisme deleted the 0-10-stable branch October 5, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants