Re-add thread_safe gem as explicit dependency #2456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Rails 7.1 does no longer require it, but AMS relies on it
| @@ -40,7 +40,8 @@ Gem::Specification.new do |spec| | |||
| # 'i18n, | |||
| # 'tzinfo' | |||
| spec.add_development_dependency 'minitest', ['~> 5.0', '< 5.11'] | |||
| # 'thread_safe' | |||
|
|
|||
| spec.add_dependency 'thread_safe','~> 0.3', '>= 0.3.4' | |||
There was a problem hiding this comment.
can we be explicit here: add_development_dependency or add_runtime_dependency
There was a problem hiding this comment.
I assumed when running tests against Rails 7.1 it will be needed as well as in production.
|
Actually this issue might have only existed with the Release Candidate version of Rails. Or together with some older gem versions. Now with our app on Rails 7.1.1 and all gem dependencies updated, it does no longer produce error messages without having the As I can not reproduce the situation anymore that lead to the AMS / thread_safe error messages, I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rails 7.1 does no longer require the
tread_safegem, but AMS relies on it, which leads to error messages.Changes
Re-adding the
thread_safegem as explicit dependency.Caveats
None known.
Related GitHub issues
Additional helpful information
I am using the same version requirements AMS used to have. In the Rails 7.1.1 app with AMS 0.10.14 I am maintaining,
thread_safe 0.3.6has been installed.