[0.9 stable] Lazily compute possible serializer class names #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point computing them all and then later look them up.
bf4
reviewed
Apr 11, 2024
| serializer = Serializer.serializers_cache.fetch_or_store(klass_name) do | ||
| _const_get(klass_name) | ||
| end | ||
| return serializer unless serializer.nil? |
There was a problem hiding this comment.
Hmm, I try to avoid return in a block. Break would work, too, no?
There was a problem hiding this comment.
Break could work yes. I find return from a block quite idomatic, but feel free to change the style if you feel strongly about it.
The goal here was first and foremost to reduce the overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point computing them all and then later look them up.
cc @bf4