Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for root keys #680

Merged
merged 1 commit into from
Oct 14, 2014

Conversation

NullVoxPopuli
Copy link
Contributor

I noticed root keys couldn't be set from the controller's render json options.

class_name.safe_constantize
when Class
config.adapter
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how embarassing :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just using the SublimeText plugin, Beautify Ruby

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant how embarrassing that I committed a bunch of tabs! This is a good patch.

@guilleiguaran
Copy link
Member

can you squash your commits in a single one?

remove debugging gem

fix white space
@NullVoxPopuli
Copy link
Contributor Author

All Squashed

@guilleiguaran
Copy link
Member

LGTM 😃 /cc @steveklabnik

@sogamoso
Copy link

👍

@buritica
Copy link

LGTM

steveklabnik added a commit that referenced this pull request Oct 14, 2014
@steveklabnik steveklabnik merged commit 9d344b1 into rails-api:master Oct 14, 2014
@steveklabnik
Copy link
Contributor

Thank you!

@NullVoxPopuli NullVoxPopuli deleted the add-root-option branch October 14, 2014 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants