:serializer option now can take a symbol as a method to call.
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handy for specifying a custom serializer class based on conditionals. Fix suggestion for rails-api#825
|
👍 |
| elsif serializer.is_a?(Symbol) | ||
| source_serializer.send(serializer) | ||
| else | ||
| serializer |
There was a problem hiding this comment.
Interesting point. I'm not really sure what I think about it.
This code could be
case serializer
when String then serializer.constantize
when Symbol then source_serializer.send(serializer)
else serializer
end
There was a problem hiding this comment.
this looks a bit cleaner (the case/when)
|
@rails-api/ams Do we want to continue with this? |
|
Pls let me know if you want me to update the code and rebase it /cc @remear |
|
I have very little knowledge of 0.8. cc @joaomdmoura ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix suggestion for #825
This is handy for specifying a custom serializer class based on
conditionals.