Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering array objects that doesn't have serializers #962

Merged
merged 8 commits into from
Jun 26, 2015
Merged

Rendering array objects that doesn't have serializers #962

merged 8 commits into from
Jun 26, 2015

Commits on Jun 26, 2015

  1. adding new tests to cover array and object rendering

    @joaomdmoura
    joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    d589268 View commit details
    Browse the repository at this point in the history

  2. fixing array rendering when elements doesn't have a serializer

    @joaomdmoura
    joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    189b795 View commit details
    Browse the repository at this point in the history

  3. Add some failing tests around has_many assocs... 

    ..where no serializer is defined for the thing that is has_many'd
    @JustinAiken @joaomdmoura
    JustinAiken authored and joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    3710c32 View commit details
    Browse the repository at this point in the history

  4. Fix rails-api#955

    @bf4 @joaomdmoura
    bf4 authored and joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    cf77786 View commit details
    Browse the repository at this point in the history

  5. Handle special-case of Array serializer with unserializable elements

    @bf4 @joaomdmoura
    bf4 authored and joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    e5d1e40 View commit details
    Browse the repository at this point in the history

  6. Renaming Error to NoSerializerError

    @joaomdmoura
    joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    d3649d5 View commit details
    Browse the repository at this point in the history

  7. updating tests to work with new virtual_value implementation

    @joaomdmoura
    joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    741c4a4 View commit details
    Browse the repository at this point in the history

  8. Account for different handling of symbol keys in Rails 4.0 

    Comparing as a JSON string vs. as the Hash that is convert to JSON
works around the different Hash representations.

This likely has to do with the introduction of
config.action_dispatch.perform_deep_munge in Rails 4.1
See Rails issue 13420

  1) Failure:
  ActiveModel::Serializer::Adapter::Json::HasManyTestTest#test_has_many_with_no_serializer
  [active_model_serializers/test/adapter/json/has_many_test.rb:36]:
  --- expected
  +++ actual
  @@ -1 +1 @@
  -{:id=>42, :tags=>[{"attributes"=>{"id"=>1, "name"=>"#hash_tag"}}]}
  +{:id=>42, :tags=>[{"attributes"=>{:id=>1, :name=>"#hash_tag"}}]}

  2) Failure:
  ActiveModel::Serializer::AssociationsTest#test_has_many_with_no_serializer
  [active_model_serializers/test/serializers/associations_test.rb:74]:
  --- expected
  +++ actual
  @@ -1 +1 @@
  -[{"attributes"=>{"name"=>"#hashtagged"}}]
  +[{"attributes"=>{:name=>"#hashtagged"}}]
    @bf4 @joaomdmoura
    bf4 authored and joaomdmoura committed Jun 26, 2015
    Configuration menu
    Copy the full SHA
    17d560e View commit details
    Browse the repository at this point in the history