Add option "key" to serializer associations #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome @Rodrigora, thank you so much for you help! ❤️ |
Rodrigora
force-pushed
the
add-key-option-to-associations
branch
from
a614fcc
to
df63b59
Compare
|
Nice @joaomdmoura! Glad to this PR passed 😄 I added an example to README as requested. Thank you! |
|
Awesome! I'm merging it @Rodrigora |
joaomdmoura
added a commit
that referenced
this pull request
Jul 6, 2015
Add option "key" to serializer associations
|
Thank you @joaomdmoura 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all
I tried to implement a solution required in #882.
I changed the
each_associationblock parameter fromnametokey. I thought this is ok, since theadapter uses this parameter to set hash keys of associations.
I also added one more test file (
test/adapter/json_api/json_api_test.rb) to test JsonApiAdapter's associations keys. Please, review if it is ok.