Support Multiple Set-Cookie Headers #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Gateway has supported multi-value parameters (https://aws.amazon.com/about-aws/whats-new/2018/10/amazon-api-gateway-adds-support-for-multi-parameters/) for some time. This includes response headers such as
Set-Cookie
for both REST API and HTTP API. Even ALB integrations support this:This article (https://medium.com/@lancers/amazon-api-gateway-explaining-lambda-payload-version-2-0-in-http-api-24b0b4db5d36) does a really good job of breaking down the two AWS references docs.
The problem? Rack's HTTP spec (https://github.com/rack/rack/blob/master/SPEC.rdoc#the-headers-) for multiple values in a single
Set-Cookie
header is to join them with a\n
new line character. We can not pass this as is to API Gateway or an ALB. Instead we pull theSet-Cookie
header from the standardheaders
response and instead pass it via the proper interface ofcookies
ormultiValueHeaders
as needed.