Prepare for v2.1.3

[aharpervc]

Now, need to remember how to build & push these gems correctly.

This will close #458 & #434 when I merge & push the final release

[aharpervc]

Welp it looks like at least Travis is rebuilding master every time I push to this branch, which is super lame, so I guess I'll look at that configuration now.

[aharpervc]

I have pushed 2.1.3-pre to rubygems for testing

[aharpervc]

I will move the openssl change out of this branch before merging. If nobody has any other objections I will try to merge & push v2.1.3 final next week.

[swatosh]

Thanks for the nudge to report! We tested 2.1.3-pre with ruby 2.5.5 and 2.6.5 and rails 5.2.4.2 at work and we are all green. (Not that this tells you much, but I suppose it's better than nothing)

…

On Fri, Apr 17, 2020 at 10:23 AM Andrew Harper ***@***.***> wrote: I will move the openssl change out of this branch before merging. If nobody has any other objections I will try to merge & push v2.1.3 final next week. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#462 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVOPMOFV6KV5SSSD3VOY5DRNCGAZANCNFSM4MED4L3Q> .

[ecentell-CPF]

Do you know when v2.1.3 final might be pushed? Thanks!

[aharpervc]

The next step is to slice out that openssl url change to a separate PR, get that merged, then rebase this branch & remove the -pre. Then it can be merged, and then I can build & push the gems.

e: actually, I just tried it again and the original openssl url is now working. Maybe the former was a temporary failure? I'll revert that change and see what happens.

e2: now blocked on figuring out what's going on here #465

[ecentell-CPF]

Can you provide an update @aharpervc thanks!

[aharpervc]

Can you provide an update @aharpervc thanks!

The current status is that this is blocked on #465, as I said. I don't want to ship a broken gem, so figuring out what is going on there is a prerequisite for shipping. Anyone can contribute to that investigation, so if getting 2.1.3 deployed is a priority for you, then any assistance you can provide to resolving the blocking issue will help make that happen.

[aharpervc]

I foolishly published the Linux version to rubygems before building the Windows version, but of course now I'm having a problem building it 🤦‍♂️. I am investigating, and hopefully all versions will be published soon

For posterity, this is the current error:

builddir="`pwd`"; cd libcharset && make all && make install-lib libdir="$builddir/lib" includedir="$builddir/lib"
make[1]: Entering directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset'
cd lib && make all
make[2]: Entering directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset/lib'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset/lib'
make[1]: Leaving directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset'
make[1]: Entering directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset'
cd lib && make all
make[2]: Entering directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset/lib'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset/lib'
cd lib && make install-lib libdir='/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib' includedir='/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib'
make[2]: Entering directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset/lib'
/bin/sh ../build-aux/mkinstalldirs /tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib
/bin/bash ../libtool --mode=install /usr/bin/install -c libcharset.la /tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib/libcharset.la

Warning: PATH set to RVM ruby but GEM_HOME and/or GEM_PATH not set, see:
    https://github.com/rvm/rvm/issues/3212

Hint: To fix PATH errors try using 'rvmsudo' instead of 'sudo', see:
    https://stackoverflow.com/questions/27784961/received-warning-message-path-set-to-rvm-after-updating-ruby-version-using-rvm/28080063#28080063

/usr/local/rvm/scripts/hook: line 33: syntax error near unexpected token `('
/usr/local/rvm/scripts/hook: line 33: `    __rvm_read_lines _hooks_list <('
libtool: install: /usr/bin/install -c .libs/libcharset.dll.a /tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib/libcharset.dll.a
libtool: install: base_file=`basename libcharset.la`
libtool: install:  dlpath=`/bin/bash 2>&1 -c '. .libs/'libcharset.la'i; echo libcharset-1.dll'`
libtool: install:  dldir=/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib/`dirname 
libtool: install: Warning: PATH set to RVM ruby but GEM_HOME and/or GEM_PATH not set, see:
libtool: install:     https://github.com/rvm/rvm/issues/3212
libtool: install: Hint: To fix PATH errors try using 'rvmsudo' instead of 'sudo', see:
libtool: install:     https://stackoverflow.com/questions/27784961/received-warning-message-path-set-to-rvm-after-updating-ruby-version-using-rvm/28080063#28080063
libtool: install: ../bin/libcharset-1.dll`
libtool: install:  test -d /tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib/.
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: and
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: https://github.com/rvm/rvm/issues
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: https://stackoverflow.com/questions/27784961/received-warning-message-path-set-to-rvm-after-updating-ruby-version-using-rvm
libtool: install: ../bin || mkdir -p /tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib/.
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: and
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: https://github.com/rvm/rvm/issues
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: https://stackoverflow.com/questions/27784961/received-warning-message-path-set-to-rvm-after-updating-ruby-version-using-rvm
libtool: install: ../bin
../libtool: line 1736: test: too many arguments
libtool: install:  /usr/bin/install -c .libs/libcharset-1.dll /tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/lib/.
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: and
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: https://github.com/rvm/rvm/issues
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: .
libtool: install: https://stackoverflow.com/questions/27784961/received-warning-message-path-set-to-rvm-after-updating-ruby-version-using-rvm
libtool: install: ../bin/libcharset-1.dll
/usr/bin/install: target '../bin/libcharset-1.dll' is not a directory
Makefile:82: recipe for target 'install-lib' failed
make[2]: *** [install-lib] Error 1
make[2]: Leaving directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset/lib'
Makefile:43: recipe for target 'install-lib' failed
make[1]: *** [install-lib] Error 2
make[1]: Leaving directory '/tmp/tmp/i686-w64-mingw32/ports/libiconv/1.15/libiconv-1.15/libcharset'
Makefile:42: recipe for target 'lib/localcharset.h' failed
make: *** [lib/localcharset.h] Error 2

That's a new one for me...

[aharpervc]

This is almost certainly a path problem when building from Windows hosts, but with help from @bvogelzang all copies are now pushed to rubygems