Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2.1.4 #486

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

aharpervc
Copy link
Contributor

@aharpervc aharpervc commented Jan 19, 2021

todo

@aharpervc
Copy link
Contributor Author

Updated to pre2 with the false fix, cc @bvogelzang @wpolicarpo. One of us will cut a new release shortly. BTW I took the liberty of squashing your PR's down to a single commit just for this preview branch only; each one can merge to master with whatever is the appropriate number of commits.

@swatosh
Copy link

swatosh commented Apr 12, 2021

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks!

(If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?)

For the silent majority: Thank you for this gem, it's been fantastic!

@aharpervc
Copy link
Contributor Author

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks!

(If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?)

For the silent majority: Thank you for this gem, it's been fantastic!

My preference is to avoid anything else that would extend the timeframe for getting this release out. We can always cut a new version with new changes once they are all approved.

Is something broken with OpenSSL right now? Is there already an issue or PR tracking this request? (If not, can you make it?)

@swatosh
Copy link

swatosh commented Apr 12, 2021

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks!
(If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?)
For the silent majority: Thank you for this gem, it's been fantastic!

My preference is to avoid anything else that would extend the timeframe for getting this release out. We can always cut a new version with new changes once they are all approved.

Is something broken with OpenSSL right now? Is there already an issue or PR tracking this request? (If not, can you make it?)

There are two CVEs in OpenSSL 1.1.1j that our security folks are on about. No PR that I know of. I can try, but I don't really have any kind of development environment, so it'll be iffy.

@swatosh
Copy link

swatosh commented Apr 12, 2021

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks!
(If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?)
For the silent majority: Thank you for this gem, it's been fantastic!

My preference is to avoid anything else that would extend the timeframe for getting this release out. We can always cut a new version with new changes once they are all approved.
Is something broken with OpenSSL right now? Is there already an issue or PR tracking this request? (If not, can you make it?)

There are two CVEs in OpenSSL 1.1.1j that our security folks are on about. No PR that I know of. I can try, but I don't really have any kind of development environment, so it'll be iffy.

So I created a PR. Seems trivial, but as I mentioned, I don't really have a development environment. Hope it's near what's needed

@aharpervc aharpervc force-pushed the prepare-for-2.1.4 branch 4 times, most recently from 0ad0f12 to 7cb8b3b Compare May 7, 2021 18:06
@aharpervc aharpervc marked this pull request as ready for review May 10, 2021 20:47
@aharpervc aharpervc merged commit 5906617 into rails-sqlserver:master May 10, 2021
@aharpervc aharpervc deleted the prepare-for-2.1.4 branch May 10, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants