-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 2.1.6 #540
Prepare for 2.1.6 #540
Conversation
Prepare for 2.1.6
Append PRE
Looks like the artifact issue is fixed via PR #541 which was mentioned as a prerequisite (#533 ) to this PR. Can we move ahead @aharpervc @andyundso |
I would leave this PR to @aharpervc , as he has ultimately permissions to publish a new gem version. but the PR itself looks good to me. |
Hello @aharpervc any chance to look into this? |
Yeah, seems fine to me. I don't see the gem files on the artifacts page in CircleCI, though. It seems prudent to push 2.1.6.pre to rubygems before merging this branch. Thoughts? |
@andyundso can you comment on the disposition of the artifacts? I second the approach of getting the push to rubygems so I can test that side of the equation. |
Three things. First, I think I never added artifact upload for the "plain" gem, like used in the Linux tests, only the platform-specific versions from Windows. Second, CircleCI appears to delete artifacts after 30 days.
I just re-run the pipeline on the master branch, and there the artifacts appear again, e.g. here. Third, your branch is behind, so even if you re-run your build, the Windows artifacts will not appear as the fix from #541 is not included. |
Thank you for pointing out the branch needing a refresh, I have finished the re sync. |
@aharpervc I see the artifacts for the windows gems in Circle now, can you verify on your side? (edited for clarity) |
Hello @aharpervc any chance to look into this? |
@ecentell-CPF I will do some final tests until Tuesday and then release 2.1.6 to RubyGems. |
Prepare for 2.1.6