Test installation on Windows without precompiled code #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d (C:/Ruby32-x64/msys64/ucrt64/include/freetds) (cherry picked from commit eb5f8ed)
I tried couple of things in order to get msys2 to run with Ruby 2.4, going so far that I even manually installed msys2. However, this also failed, but I found a StackOverflow thread about it: https://stackoverflow.com/questions/73985340/error-target-not-found-when-trying-to-install-msys2-and-mingw-development-toolc But this seems to much to me: If we need to go such lengths in order to test a "minor" thing for one Ruby version, I rather don't do it.
andyundso
force-pushed
the
install-on-windows
branch
from
9eb07b5
to
8b3301c
Compare
|
as discussed with @aharpervc via mail, we want to include this fix in the next release, so I'm going ahead and merge this branch. |
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds jobs to the CircleCI pipeline to test the fix submitted by @Largo in #536. The jobs install the gem on Windows without any precompiled code and executes it afterwards.
This branch also includes the commit from @Largo which fixes the installation.
This new job does not run with Ruby 2.4. The msys2 installation for older Ruby versions is old as well, but from Ruby 2.5, we can update it using a key refresh. With Ruby 2.4,
pacman-keywas no available in the shipped msys2 version. I tried to manually install a new version of msys2. Then,ridk install 2 3failed because it tried to install quite old versions of automake. There was a fix for this as well, but if we need to go such lengths for testing on EOL Ruby versions, I rather don't do it.