New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Rails 5 #12
Commits on Aug 26, 2015
-
Bump dependencies for ActionPack
ActionPack has removed `deep_munge` and this gem no longer works with Rails 5. This bumps the dependency for ActionPack which requires Rack 2.0 so I added that to the Gemfile as well since it's unreleased.
Configuration menu - View commit details
-
Copy full SHA for af7a449 - Browse repository at this point
Copy the full SHA af7a449View commit details -
Replace
deep_munge
withnormalize_encode_params
`deep_munge` no longer exists. We should now use `normalize_encode_params`
Configuration menu - View commit details
-
Copy full SHA for 7efe0eb - Browse repository at this point
Copy the full SHA 7efe0ebView commit details -
Make AC::Parameters not inherited from Hash
Following rails/rails#20868 changed how ActionController::Parameters worked. This change makes `dump_param_keys` match how the Rails side reads teh hash keys. Without this change the right keys don't make it to `Request::Utils` so the test `test_dasherized_keys_as_xml` was failing because `sub-key` wasn't being recognized as a key.
Configuration menu - View commit details
-
Copy full SHA for ca0d9ce - Browse repository at this point
Copy the full SHA ca0d9ceView commit details -
Fix deprecation warning about passing strings to middleware
Passing middleware as strings or symbols is now deprecated. ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::XmlParamsParser" => ActionDispatch::XmlParamsParser ```
Configuration menu - View commit details
-
Copy full SHA for 81839fd - Browse repository at this point
Copy the full SHA 81839fdView commit details -
Fix deprecation warnings about keyword args
It is now required that HTTP request methods pass keyword arguments instead of params without keywords. This fixes the following deprecation warning: ``` DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request methods will accept only the following keyword arguments in future Rails versions: params, headers, env, xhr Examples: get '/profile', params: { id: 1 }, headers: { 'X-Extra-Header' => '123' }, env: { 'action_dispatch.custom' => 'custom' }, xhr: true ```
Configuration menu - View commit details
-
Copy full SHA for 526ffaf - Browse repository at this point
Copy the full SHA 526ffafView commit details -
Fix deprecation warnings by switching
text
toplain
Fixes deprecation warning to swicth from using `render text:` to `render plain:`. ``` `render :text` is deprecated because it does not actually render a `text/plain` response. Switch to `render plain: 'plain text'` to render as `text/plain` ```
Configuration menu - View commit details
-
Copy full SHA for 75fab06 - Browse repository at this point
Copy the full SHA 75fab06View commit details
Commits on Sep 8, 2015
-
Bump required Ruby version and update travis.yml
Rails 5 requires Ruby 2.2.2 and will fail on versions lower than 2.2.2. This change removes the versions that cannot work with the changes to Rails 5 and actionpack-xml_parser. Updates corresponding .travis.yml file so that master no longer runs against those.
Configuration menu - View commit details
-
Copy full SHA for 8ea038d - Browse repository at this point
Copy the full SHA 8ea038dView commit details