Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Rails 5 #12

Merged
merged 7 commits into from Sep 10, 2015
Merged

Commits on Aug 26, 2015

  1. Bump dependencies for ActionPack

    ActionPack has removed `deep_munge` and this gem no longer works with
    Rails 5.
    
    This bumps the dependency for ActionPack which requires Rack 2.0 so I
    added that to the Gemfile as well since it's unreleased.
    eileencodes committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    af7a449 View commit details
    Browse the repository at this point in the history
  2. Replace deep_munge with normalize_encode_params

    `deep_munge` no longer exists. We should now use
    `normalize_encode_params`
    eileencodes committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    7efe0eb View commit details
    Browse the repository at this point in the history
  3. Make AC::Parameters not inherited from Hash

    Following rails/rails#20868 changed how
    ActionController::Parameters worked.
    
    This change makes `dump_param_keys` match how the Rails side reads teh
    hash keys.
    
    Without this change the right keys don't make it to `Request::Utils` so
    the test `test_dasherized_keys_as_xml` was failing because `sub-key`
    wasn't being recognized as a key.
    eileencodes committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    ca0d9ce View commit details
    Browse the repository at this point in the history
  4. Fix deprecation warning about passing strings to middleware

    Passing middleware as strings or symbols is now deprecated.
    
    ```
    DEPRECATION WARNING: Passing strings or symbols to the middleware
    builder is deprecated, please change
    them to actual class references.  For example:
    
      "ActionDispatch::XmlParamsParser" => ActionDispatch::XmlParamsParser
    ```
    eileencodes committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    81839fd View commit details
    Browse the repository at this point in the history
  5. Fix deprecation warnings about keyword args

    It is now required that HTTP request methods pass keyword arguments
    instead of params without keywords.
    
    This fixes the following deprecation warning:
    
    ```
    DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
    methods will accept only the following keyword arguments in future
    Rails versions:
    params, headers, env, xhr
    
    Examples:
    
    get '/profile',
      params: { id: 1 },
      headers: { 'X-Extra-Header' => '123' },
      env: { 'action_dispatch.custom' => 'custom' },
      xhr: true
    ```
    eileencodes committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    526ffaf View commit details
    Browse the repository at this point in the history
  6. Fix deprecation warnings by switching text to plain

    Fixes deprecation warning to swicth from using `render text:` to `render
    plain:`.
    
    ```
    `render :text` is deprecated because it does not actually render a
    `text/plain` response. Switch to `render plain: 'plain text'` to render
    as `text/plain`
    ```
    eileencodes committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    75fab06 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2015

  1. Bump required Ruby version and update travis.yml

    Rails 5 requires Ruby 2.2.2 and will fail on versions lower than 2.2.2.
    This change removes the versions that cannot work with the changes to
    Rails 5 and actionpack-xml_parser. Updates corresponding .travis.yml
    file so that master no longer runs against those.
    eileencodes committed Sep 8, 2015
    Configuration menu
    Copy the full SHA
    8ea038d View commit details
    Browse the repository at this point in the history