Fixes to the has_many finder builder #179
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR to any Rails project, so let me know if I'm overstepping my bounds or if I missed the memo about how all this works.
I am attempting to resolve two bugs in the
has_many
association (one documented, one not).The undocumented bug is that if you call a
has_many
association on a new record, it returns the collection parser for that record's class. It should probably return the collection parser for the associated class, no?The other bug is documented here and here. In short, the documentation says:
But that does not seem to be the case. In actuality, the behavior generates a URL like:
I believe this PR fixes both those bugs. But I will do further testing to be sure.