Always return a boolean value for ActiveResource::Base#exists?
#375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the source code, I noticed that
ActiveResource::Base#exists?
included a line of code that was commented out.I also noticed that
ActiveResource::Base#exists?
could return three values:nil
,false
, andtrue
. InActiveRecord
, the#exists?
method always returns a boolean value. With this change, theActiveResource::Base#exists?
now always returns a boolean value.