Skip to content

Commit

Permalink
limit members of the AST are visited
Browse files Browse the repository at this point in the history
  • Loading branch information
@tenderlove
tenderlove committed Dec 7, 2010
1 parent 4018b5d commit 0c20538
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions History.txt
View file
@@ -1,3 +1,9 @@
== 2.0.7 (unreleased)

* Bug Fixes

* Limit members are visited

== 2.0.6 12/01/2010

* Bug Fixes
Expand Down

1 comment on commit 0c20538

@metaskills
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember ActiveRecord had tests that a #to_i conversion was done on limit/offset which was good for params string options be passed down. Is this still the case? I noticed your tests just visit the object so "20-xyx" would not be 20 anymore. Does it not matter for other DBs to have LIMIT '20' vs LIMIT 20? In the case of SQL Server it will come out to TOP (N'20') if a string is passed in, unless I am missing something at this stage and what I am seeing for tests under 2.0.2 and passing :limit => '20'

Please sign in to comment.