Improve error message when passed unsupported type #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeodor
referenced
this pull request
Jun 18, 2015
|
Seems fine to me. Maybe we should add a specific exception instead of just raising a runtime exception? |
|
@tenderlove I added another commit 145f32a for that. Is it what you had in mind? |
rafaelfranca
added a commit
that referenced
this pull request
Dec 17, 2015
Improve error message when passed unsupported type
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that is the best message, but I think the message needs improving, so I wanted to open a discussion about this.
If the message as I changed it makes sense in the context of all the different ways in which
unsupportedmight be called, then I suppose maybe it's OK as-is. But it looked like maybe there's a better way to say it.Basically, when upgrading some code that was failing after having worked with a
String, it took me quite a while to figure out what this "unsupported: String" message was about, and to do so, I had to read through Arel's code. So I thought it would be better to give the other programmer some direction to where they wouldn't need to do that.It would be even better if we could point them to a specific section of the docs that addresses how to work in Arel.
What do you think?