Add mysql 5.7 build #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we're only running mysql 8 builds which has resulted in merging broken changes in mysql 5.7 that we end up finding when we run tests locally. Running with both 8 and 5.7 will ensure that all new features to active record are supported by both databases, or cases where they aren't supported, we can handle those cases in PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're only running mysql 8 builds which has resulted in
merging broken changes in mysql 5.7 that we end up finding when we run
tests locally. Running with both 8 and 5.7 will ensure that all new
features to active record are supported by both databases, or cases
where they aren't supported, we can handle those cases in PRs.