Add skip_digest option key to allow bypassing cache digestion #16

Merged
merged 1 commit into from Nov 25, 2012

Conversation

Projects
None yet
3 participants
Contributor

latortuga commented Nov 24, 2012

In addition to the already present bypass method of passing an explicitly version numbered cache key (e.g. ['v1','cache-key']), this adds an option to the cache in order to give control in bypassing the digest append step on a case-by-case basis.

Discussion in #12.

@latortuga latortuga Add skip_digest option key to allow bypassing cache digestion
In addition to the already present bypass method of passing an explicitly
version numbered cache key (e.g. ['v1','cache-key']), this adds an option
to the cache in order to give control in bypassing the digest append step
on a case-by-case basis.
fc45854

dhh merged commit 4e679af into rails:master Nov 25, 2012

Owner

dhh commented Nov 25, 2012

Great work. Can you get this fix into rails/master as well?

Contributor

latortuga commented Nov 25, 2012

Yes absolutely. I will post again when I submit it.
On Nov 25, 2012 5:49 AM, "David Heinemeier Hansson" <
notifications@github.com> wrote:

Great work. Can you get this fix into rails/master as well?


Reply to this email directly or view it on GitHubhttps://github.com/rails/cache_digests/pull/16#issuecomment-10692616.

Fantastic. Thanks.

Contributor

latortuga commented Nov 26, 2012

@dhh @phuongnd08 I have a unit test and an implementation for skip_cache: true in rails master however there is currently no support for cache_digests' explicitly_versioned_cache_key? check. Would you like me to add that implementation as well?

@latortuga: I don't understand cache_digests that well to know if such method is necessary or not :) Let's hear from @dhh then.

@sgerrand sgerrand pushed a commit to sgerrand/rails that referenced this pull request Nov 2, 2013

@latortuga latortuga Add explicit opt-out for fragment cache digesting
This add support for sending an explicit opt-out of the "Russian-doll"
cache digest feature on a case-by-case basis. This is useful when cache-
expiration needs to be performed manually and it would be otherwise
difficult to know the exact name of a digested cache key.

More information: rails/cache_digests#16
7fb8c67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment